Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add initial support for expressions #411

Merged
merged 1 commit into from
Mar 11, 2021
Merged

Add initial support for expressions #411

merged 1 commit into from
Mar 11, 2021

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Feb 23, 2021 •
edited
Loading

This PR introduces support for a few expression types as described in more detail in hashicorp/hcl-lang#16

This is a first step and future PRs will bring support for more expression types, so that we can eventually resolve the following:

Examples

Screenshot 2021-02-23 at 15 04 04
Screenshot 2021-02-23 at 15 04 23
Screenshot 2021-02-23 at 15 04 46
Screenshot 2021-02-23 at 15 05 34
Screenshot 2021-02-23 at 15 06 09
Screenshot 2021-02-23 at 15 06 25
Screenshot 2021-02-25 at 10 13 57

@radeksimko radeksimko force-pushed the f-expressions branch 4 times, most recently from 79f4812 to 148328d Compare February 25, 2021 10:12
@radeksimko radeksimko marked this pull request as ready for review February 25, 2021 10:49
@radeksimko radeksimko requested a review from a team February 25, 2021 10:51
@radeksimko radeksimko force-pushed the f-expressions branch 2 times, most recently from 98988bd to fb0b0c9 Compare February 26, 2021 12:17
@radeksimko radeksimko mentioned this pull request Feb 26, 2021
Merged
aeschright
aeschright approved these changes Mar 11, 2021
View reviewed changes
Copy link
Contributor

@aeschright aeschright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@radeksimko radeksimko merged commit e4e017d into main Mar 11, 2021
@radeksimko radeksimko deleted the f-expressions branch March 11, 2021 19:19
@ghost
Copy link

ghost commented Apr 10, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the context necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators Apr 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aeschright aeschright aeschright approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request textDocument/completion textDocument/documentSymbol textDocument/hover
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radeksimko @aeschright